Addition of the adjoint of the fdiff function from ImageBase.jl#26
Open
arcAman07 wants to merge 14 commits intoFluxML:mainfrom
Open
Addition of the adjoint of the fdiff function from ImageBase.jl#26arcAman07 wants to merge 14 commits intoFluxML:mainfrom
arcAman07 wants to merge 14 commits intoFluxML:mainfrom
Conversation
Fix whitespace
fdiff adjoint added
Contributor
Author
|
Not sure why some of the tests are not passing, they are working for me locally |
Collaborator
johnnychen94
left a comment
johnnychen94
left a comment
There was a problem hiding this comment.
Looks good at first look. Will check the details this weekend.
Contributor
Author
Great!, will accordingly work on adding other adjoints for utility functions in ImageBase.jl |
Contributor
Author
|
Updated the fdiff adjoint by making it shorter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deals with the addition of the adjoint ( AD ) for the fdiff function ( Forward Difference ) from ImageBase.jl. Adjoint is written for the function along with the corresponding tests. Tagging the mentors for review @johnnychen94 @DhairyaLGandhi .